Get the latest tech news
Code review can be better
Insights, updates, and technical deep dives on building a high-performance financial transactions database.
Slightly unusual genre today: a negative result about our git-review tool for a different take on code review process, which we decided to shelve, at least for the time being. Alas, when I want to actually leave feedback on the PR, I have to open the browser, navigate to the relevant line in the diff, and (after waiting for several HTTP round-trips) type my suggestion into a text area. There is an impedance mismatch here, where, for code, we want very strong, hash-chained intentional sequence of state-transitions, while for review we would be more happy with more lax conflict-free merging rules.
Or read this on Hacker News
